[cli] Switch to WaitForEffectsCert for CLI
#19375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
stefan-mysten
force-pushed
the
sdk_fix_local_execution
branch
from
e45e24c to
0b9f129
Compare
stefan-mysten
changed the title
WaitForEffectsCert for execute_transaction_may_failWaitForEffectsCert for CLI
lxfind
approved these changes
Sep 14, 2024
stefan-mysten
changed the title
WaitForEffectsCert for CLIWaitForEffectsCert for CLI
stefan-mysten
force-pushed
the
sdk_fix_local_execution
branch
2 times, most recently
from
0e69c51 to
bc38d69
Compare
lxfind
approved these changes
Sep 16, 2024
stefan-mysten
force-pushed
the
sdk_fix_local_execution
branch
from
34fc502 to
8b39980
Compare
stefan-mysten
added a commit
to stefan-mysten/sui
that referenced
this pull request
Sep 17, 2024
This reverts commit bf86ff9.
8 tasks
stefan-mysten
added a commit
that referenced
this pull request
Sep 17, 2024
## Description This reverts PR #19375. Unclear how to handle `waitForLocalExecution` in the CLI for now. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new function
execute_txthat is used only in the CLI that usesWaitForEffectsCertinstead ofWaitForLocalExecutionto align with the deprecation of waiting for local execution.Also added the polling for transaction like in https://github.com/MystenLabs/sui/pull/18996/files
Test plan
Existing tests.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
WaitForEffectsCertin the quorum driver for transaction execution. As a result, it uses polling to simulateWaitForLocalExecution.